Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Fixed all banking locations in include and logic - delete your settings file before re-running!
Also it's a good idea to have my scripts in their own folders so the settings files don't get mixed up. Oh and make sure to update your srl before running!
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Hey bro, any chance of getting Edgeville bank added as it's own option? Bank_npc_blue works sufficiently well, but it does have it's hangups now and again at Edgeville. A lot of times my toon will run back and forth from banker to banker every few opens, and looks really bot-like. Maybe even something like bankscreen.optn(BANK_COUNTER); would work really well at Edgeville. There is a design on the top of the counter that might just be great for a DTM.
Just a suggestion. I make due with _BLUE, but it could be better. Thanks.
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Hey bro, 2 things.
First, I'm noticing this script is failing to stop about 50% of the time when it's out of herbs making unf's. I use Preset 2, and it just keeps looping. Bank, withdrawal, not making anything, bank, withdrawal...etc. I've come back to the entire chatbox filled with "Item not found: Clean 'herb'". Since the whole box was full, I'm unsure how many loops it had actually done. The times it does stop, the termination message is "Nothing has happened...too long" instead of "Failed Withdrawing". I've seen failed withdrawal a few times, but 9 out of 10 times it actually does stop, its because nothing happened too long. I tried looking through the script to find the issue, but sadly it's still a bit advanced for me. The one thing I could suggest, is instead of Until Not (TabBackpack.IsItemInSlot(28));, start looking for Until Not (TabBackpack.IsItemInSlot(14));, since if you're out of herbs, or have less than 14, slot 14 will be empty. This only applies to using the presets, not to normal banking.
Second thing is, has the chatbox reading been fixed yet? If it hasn't I'll take a crack at gathering the images. Just let me know if it's SmallChars, or SmallCharsNS that needs to be replaced.
Yeah that's caused by a couple of things
1) The failsafe is there to read the red text & shut down, however it's broken in the include. I believe @Olly; has the fix but has been holding out for a new version of simba or someshing
2) Since that doesn't work, it still should shut down if you have herbs as the second item (so slot 28 won't be filled). I don't want to use the full function since mouseovertext can cover some of the slots. So it should still shut down if you switch the items around (pots first 14 slots, herbs last 14 slots).
3) It will still timeout after a few minutes of failing to do anything... but agreed the hitting of preset button every 20 or so seconds is annoying (if #1 is fixed we wouldn't have to worry about any of it)
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Just realized a huge problem with this.
Pots made/ hr = 182Code:|=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=| | AshamanHerblore v2.2 | |=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=| | Running For: 1 Hours, 18 Minutes and 25 Seconds | | Toadflax potion (unf)'s Made: 238 Made/H: 182 | | Exp Earned: 0 Exp/Hour: 0 | |___________________________________________________________| |___________________________________________________________|
With the scroll of cleansing, there is a very good chance that slot 28 won't change, because it saves the herbs. This is causing the script to wait far too long between loads. It would be the same effect with my suggestion for slot 14. How can we correct this? We need a failsafe for failed withdrawal, but it can't be looking for an inv slot.
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
It doesn't necessarily stay in that spot, it will just use it on the next potion made. If you save 3 herbs in one load, slots 14, 13, and 12 will still have herbs.
The pic below saved 2 herbs in that load.
svdhrb.jpg
So if the script was waiting for slot 13 or 14 to change, it would have waited the max time.
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
I guess that's kinda confusing. I moved the herbs back to the top 14 to prevent the max wait issue. Here is a pic of the herbs on the bottom.
svdhrb28.jpg
Herbs on top create the "won't terminate" issue, herbs on the bottom create the "max wait" issue.
I made a short vid of both processes.
EDIT: Video removed, purpose served.
Ok that's right... herbs should be first i forgot. Hmm was the inventory full when it did the "nothing has happened for too long" error? B/c when you use presets, it will print that same message for every slot it can't fill.
So that image it printed like 10 times since there were 10 slots it couldn't fill, even though it only failed withdrawing once & then shut down... are you sure that wasn't the issue?
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
No it was 10 full loops of the script, or however many it actually was. The chatbox was filled with "Your preset is being withdrawn, please see below for any issues whilst trying to load it." Followed by multiple red texts, followed by "Your preset...", red text, preset, red text...etc. So it banked, clicked the preset, stood still for max wait, banked, clicked preset etc.
Edit: I think I've figured it out. It does need to be looking at slot 14 when it verifies withdrawal. It needs to look at 28 to see when the load is done. I believe right now it is looking at 28 for both withdrawal and load done, and unless you're out of vials, withdrawal will always return true. It won't know it's out of herbs.
Last edited by Ashaman88; 06-05-2014 at 02:28 AM.
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Hello, how can I add new players?
Begin
Players.Setup(['Player1'], 'PlayerList'); //***Fill this out, Player1 = Name of the account in player manager, PlayerList = name of the player file***
SetLength(Players,1);
//***If NOT using the player manager, fill out the loginname and password below, otherwise ignore those two***
With players[0] Do
Begin
loginName := ''; {Remove the "//" from this line if you arent using player manager}
password := ''; {Remove the "//" from this line if you arent using player manager}
IsActive := True;
World := 96; {Remove the "//" from this line if you want to set a world to login to}
BankPin := ; {Remove the "//" from this line if you arent using player manager and you have a pin}
End;
CurrentPlayer := 0;
End;
-v2.3 Hopefully fixed issue with preset withdraw method/various tweaks
I should probably add an option to use a random assortment of preset and normal withdraw... same with production screen (clicking or using space bar)... but hopefully that takes care of the real issue.
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Running it now, will report any issues. I'm not sure a hybrid-withdrawal would really be needed. I can't really see a human going back and forth between the two. They'll either be old school and stick with the normal withdrawal, or they'll strictly use the preset. The only time I could see a real human switching back and forth is if the presets are still brand new to them and they just forget to use it out of habit, but I don't think it would take them long to move to the preset 100%. However, on super small loads, say under 100, it would be more trouble than it's worth to setup presets. But who's really gonna run a script for 100 herbs?
I do think that the clickStart would benefit from such a hybrid scenario. Personally, I would like to see clickStart go back to just purely clicking instead of the spacebar. Still too often I find my toons logged out south of where they were standing because they spaced then clicked. Either that or the click wait should be increased to something like 5000. If you're lagging that badly, then efficiency is out the window anyway. That way it solves both issues, it will never miss a load because the spacebar didn't register, and it will never go running out of the bank because of the click overlap. Just my thoughts.
Anyways, looks good so far. I'll report back later. Thanks bro.
Just wanted to say this script was awesome, I used it to get to get to approx 91-92 herb. the only non-ideality was the pauses in the banking but they weren't too bad.
I would suggest maybe adding functionality for making the super mage/range pots which have a stackable secondary ingredient so you should be able to make 27 pots/inv, I had to do these manually but it wasnt that big of a deal.
I'm making unf pots, and on occasion after withdrawing preset it will click in the inventory before the locked overlay dissapears.
This is probably due to lag, but either it misses the herb (first 14 slots) then clicks vial (last 14) and ends up using vial on banker and then trying a different banker since the first attempt failed. OR it actually misses both herb and vial and then banks.
With the first circumstance, if the second banker doesn't open the bank then it waits and attempts the first banker again.
I've tried to boost my internet connection, having only 1 runescape open and nothing else. But my net just sucks.
Search in the script for BankScreen.Close; and add this to the little bit of code thats there.
itll add some wait times between closing the bank and trying to use the ingredients. Should eliminate most problems.Simba Code:if normalBank then
begin
Wait(GaussRangeInt(800, 1000));
BankScreen.Close;
Wait(GaussRangeInt(800, 1000));
end
There are currently 1 users browsing this thread. (0 members and 1 guests)