Well this isn't necessarily a script issue, the include update broke it. So hopefully one of the seniors can give me some advice.
EDIT: Fixed. If you're having trouble with this script/playerform after the newest SRL update, go here: https://raw.githubusercontent.com/SR...ayerform.simba and replace your srlplayerform.simba with that. It allows the script to run as it previously did. Hopefully in the meantime a more "official" fix can be made.
Always will try to respond to the Gunner! Yeah when I get back I'll review all the commits coming through - most made by non-devs but they are just trying to help out/pick up my slack! I would also try deleting your settings file for this script and see if that fixes the issue. Lame sauce when include breaks my script. IDK when I will respond, but might be a good idea to shout out to @Olly; about it
Red & Green Salamander Hunter // Construction // Gilded Altar // Major help w/ Kyles Runespan // VWB Smither // PhoenixFeathers // GemCutter // Bonfire // LRC Miner // Spell Tab Maker // ApeAtollAgility // IvyWC // RoguesCooker // Herblore // AshamanButterfly // AshamanPowerMiner // Fletcher // LividFarm
Just delete your settings.xml I'm sorry for the inconvenience but id rather keep it how the update made it.
Last edited by seniorjulio; 12-17-2014 at 12:20 AM.
Salute Me or Shoot Me!
I believe this should be the fix For current issue:
Current DeclarePlayers method:
To use instead:Simba Code:procedure declareplayers();
var
i,j: integer;
begin
players.setup(playerForm.playerNames, playerForm.playerFile); // load the SPF players from the SRL Player Manager
currentPlayer := 0; // player to use first
// set player attributes based on the settings from the form
for i := 0 to high(players) do
with players[i] do
begin
// convert the integers
integers[0] := strToInt(playerForm.players[i].settings[1]); //minutes until break
integers[1] := strToInt(playerForm.players[i].settings[2]); //minutes to break
for j := 0 to high(playerForm.comboBoxItems[1]) do
if (playerForm.players[i].settings[11] = playerForm.comboBoxItems[1][j]) then
integers[2] := j; //bankinglocation
Stacks := strToInt(playerForm.players[i].settings[4]); //number of stacks
World := strToInt(playerForm.players[i].settings[3]); //world
ismember:=true;
if (playerForm.players[i].settings[12] = 'Normal') then
normalBank := true;
if not normalBank then
for j := 0 to high(playerForm.comboBoxItems[2]) do //quickload
if (playerForm.players[i].settings[12] = playerForm.comboBoxItems[2][j]) then
integers[4] := j+2;
// booleans
booleans[0] := strToBool(playerForm.players[i].settings[6]); //takebreaks
booleans[1] := strToBool(playerForm.players[i].settings[7]); //switchworlds
FindMod := strToBool(playerForm.players[i].settings[8]); //mods
debug := strToBool(playerForm.players[i].settings[9]); //debug
// any other data types you've decided to use
strings[0] := playerForm.players[i].settings[0]; //quickkey
strings[1] := playerForm.players[i].settings[10]; //cleanorpots
if (not normalbank) and (strings[1] = 'Pots') then
slots := 14 else
slots := 28;
if (playerForm.players[i].settings[5] = '') then
begin
writeln('No UserAgent detected. Opening up webpage to get userAgent');
openWebPage('http://whatsmyuseragent.com/');
writeln('Copy your useragent text and paste it into the form');
writeln('Restart script');
terminateScript;
end else
smartUserAgent := playerForm.players[i].settings[5]; //useragent
print('slots: ' + toStr(slots));
end;
end;Simba Code:procedure declareplayers();
var
i,j: integer;
begin
players.setup(playerForm.playerNames, playerForm.playerFile); // load the SPF players from the SRL Player Manager
currentPlayer := 0; // player to use first
// set player attributes based on the settings from the form
for i := 0 to high(players) do
with players[i] do
begin
// convert the integers
integers[0] := strToInt(playerForm.players[i].settings[1]); //minutes until break
integers[1] := strToInt(playerForm.players[i].settings[2]); //minutes to break
for j := 0 to high(playerForm.comboBoxItems[1]) do
if (playerForm.players[i].settings[7] = playerForm.comboBoxItems[1][j]) then
integers[2] := j; //bankinglocation
Stacks := strToInt(playerForm.players[i].settings[4]); //number of stacks
World := strToInt(playerForm.players[i].settings[3]); //world
ismember:=true;
if (playerForm.players[i].settings[8] = 'Normal') then
normalBank := true;
if not normalBank then
for j := 0 to high(playerForm.comboBoxItems[2]) do //quickload
if (playerForm.players[i].settings[8] = playerForm.comboBoxItems[2][j]) then
integers[4] := j+2;
// booleans
booleans[0] := strToBool(playerForm.players[i].settings[9]); //takebreaks
booleans[1] := strToBool(playerForm.players[i].settings[10]); //switchworlds
FindMod := strToBool(playerForm.players[i].settings[11]); //mods
debug := strToBool(playerForm.players[i].settings[12]); //debug
// any other data types you've decided to use
strings[0] := playerForm.players[i].settings[0]; //quickkey
strings[1] := playerForm.players[i].settings[6]; //cleanorpots
if (not normalbank) and (strings[1] = 'Pots') then
slots := 14 else
slots := 28;
if (playerForm.players[i].settings[5] = '') then
begin
writeln('No UserAgent detected. Opening up webpage to get userAgent');
openWebPage('http://whatsmyuseragent.com/');
writeln('Copy your useragent text and paste it into the form');
writeln('Restart script');
terminateScript;
end else
smartUserAgent := playerForm.players[i].settings[5]; //useragent
print('slots: ' + toStr(slots));
end;
end;
To clarify, line 82:
89:Simba Code:if (playerForm.players[i].settings[7] = playerForm.comboBoxItems[1][j]) then97-101:Simba Code:if (playerForm.players[i].settings[8] = 'Normal') then105:Simba Code:// booleans
booleans[0] := strToBool(playerForm.players[i].settings[9]); //takebreaks
booleans[1] := strToBool(playerForm.players[i].settings[10]); //switchworlds
FindMod := strToBool(playerForm.players[i].settings[11]); //mods
debug := strToBool(playerForm.players[i].settings[12]); //debugSimba Code:strings[1] := playerForm.players[i].settings[6]; //cleanorpots
My Outdated ScriptsEdgeville Log Cutter | Edgeville AIO Jewelry | AIO Pickpocketer | Urn Activator | Slayer Tower | Slaying KuradalMy Working Scripts: Tutorials:Function Pointers and Why You Should Care! | Forms and Saving Settings | The Magic Behind Programming Tutorial | Recursive Recursion![]()
Is anybody else having problems with TRSBankScreen now? The script worked just fine after the fix until late last night. Now I'm getting an error at line 2530:
Simba Code:if not self.isSearchOpen thenSimba Code:Error: Operator "NOT" not compatible with "record [0]Pointer; [4]Pointer; end" at line 2530
Compiling failed.
Salute Me or Shoot Me!
Thanks err'body for the responses. For the time being I'll keep it the way I have it, only because I know for sure that it's working right now. After Ash gets back and has the opportunity to really pour over everything I may turn my updates back on. Thanks again all.
Umm I did the changes Kevin said and now it just goes to search for an item and the bot fails...
will update if I figure out why it's started this.
I copied the entirety of Kevin's declareplayers and it works now,
don't just change part of it like it did....
Last edited by fallacysnow; 12-17-2014 at 06:07 PM.
I tried that, tried it again, made sure the indents matched. Did the new plugin do this(are other people having this same problem), or did my cat run all over the keyboard last night? BTW this is happening for me on all scripts that use banking feature so should I move this post to SRL discusions?
Salute Me or Shoot Me!
A recent pull request was approved to SRL-6. There was a small syntax error and it broke the include. It was fixed a day ago in this commit.
Do the following:
SRL > Settings > enable Override Update
SRL > Check for update
Let the files download, then restart Simba.
GitLab projects | Simba 1.4 | Find me on IRC or Discord | ScapeRune scripts | Come play bot ScapeRune!
<BenLand100> we're just in the transitional phase where society reclassifies guns as Badâ„¢ before everyone gets laser pistols
it's amazing how well a completely new install fixes some things...
copy your simba folder from your c: drive or wherever and just delete the original and replace with the copy if it messes up again. Faster than a clean install.
Nvm didn't read what was above
working smoothCode:|=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=| | AshamanHerblore v2.6 | |=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=| | Running For: 4 Hours, 26 Minutes and 11 Seconds | | Super attack (3)'s Made: 9,072 Made/H: 2,045 | | Exp Earned: 988,116 Exp/Hour: 222,726 | | Profit: -1 Profit/Hour: -2,045 | |___________________________________________________________|![]()
1B total exp progress
875m / 1B
120s
113/120 Fish
112/120 Dung
Mine doesn't bank, can anyone help?
Thanks.
EDIT:
Got it working! Running perfectly
Edit again: Worked for around 50 minutes then I got this
Error: Invalid floating point operation at line 235
I'm assuming it's to do with the antiban line 235 says:
line 235 case i of
line 236 1: boredHuman(false);
EDIT AGAIN: Thanks a lot man you got me around 300k xp in herblore with this and 12m gp!![]()
Last edited by Antonio; 01-18-2015 at 11:36 PM.
I'm having trouble. I don't know what to do with useragent string.
Error: Too many parameters found at line 335
Compiling failed.
"If (ChooseOption.OptionsExist(['Exam','mine','Examine','Canc','ncel','Cancel'],400)) Then"
Sorry for correcting you Suikerwafel.
Change line 335 to:
If (ChooseOption.OptionsExist(['Examine','Cancel'])) Then
and change line 419 to:
If (ChooseOption.OptionsExist(['Examine','Cancel'])) Then
You will then get the updated version of the script in the "Downloads" folder.
Twas awesome using this using this when dxp was announced, made a pretty penny over a couple of nights. Currently at 97 herblore, but I'm not stoppin at 99! Cleaning herbs btw, I'll post the next proggy.
very flawless scripe got me some good xp
There are currently 1 users browsing this thread. (0 members and 1 guests)