Page 1 of 2 12 LastLast
Results 1 to 25 of 36

Thread: [ProjectRS06] Catherby Cooker

  1. #1
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default [ProjectRS06] Catherby Cook+Bank

    VERSION 4.2 IS OUT, BE SURE TO DOWNLOAD IT!


    YOU MUST HAVE THE P06 SRL INCLUDES INSTALLED FOR THIS SCRIPT TO WORK, INSTRUCTIONS ON HOW TO DO THIS CAN BE FOUND HERE!

    http://villavu.com/forum/showthread.php?t=95916

    Thanks to Danny and the team for that!


    Here's the first release of my new Catherby cooker and banker! It simply withdraws the fish you want to cook, walk to the range, cook the fish, deposits the cooked (and burnt) fish and repeats! There aren't any static co-ords so I am sure the script will be able to function for a long amount of time (perfect for the 10k+ lobs I have to cook!) I have included a lot of fail-safes too to ensure it only progresses onto the next procedure when ready to.


    INSTRUCTIONS FOR USE:
    • Ensure you have downloaded and installed the P06 SRL Includes via the link given above.
    • Start at Catherby Bank with a full or empty inventory (Doesn't matter which one)
    • Ensure your brightness is set to the maximum setting.
    • Ensure the fish you want to cook are in the first slot in your bank.
    • Ensure the color of the fish you are wanting to cook has been inserted into the field at the beginning of the script using the color picker.
    • The script is set up for lobsters currently but if it's not working for you simply re-pick the color of the lobster and insert it into the script.
    • The rest will be done for you! (Angle and compass are set via the script)



    UPDATES:
    • Added numerous checks to see if player is logged out and attempts to re-log and continue script.
    • Replaced bitmaps for right clicks with p06_choosemultioption as recommended by DannyRS!
    • Tweaked and improved various failsafes and status updates.
    • 12/feb - Fine tuned various procedures, added progress update and moved writeln to status updates instead!
    • 13/feb - Tweaked a few failsafes
    • Few Modifications



    Code:
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       Script Running, thanks for using it!
       Time Running   : 5 Hours, 9 Minutes and 53 Seconds
       Completed Runs : 151
       Fish Cooked    : 4228
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    Attached Files Attached Files
    Last edited by Janus; 02-14-2013 at 07:32 PM.

  2. #2
    Join Date
    Nov 2012
    Posts
    2,351
    Mentioned
    55 Post(s)
    Quoted
    603 Post(s)

    Default

    Nice release, I just had a look, are you using bitmaps for the right clicked options?

    You could try this, it should work for all right click stuff, and I think the text is 100% accurate on the menu, as it's all one color

    Simba Code:
    P06_ChooseOptionMulti(['Withdraw All','All']); //is there a - between the words?

    You might want to add exit's to your loops if you disconnect, and maybe add the loginplayer Include,

    Simba Code:
    If (Not P06_LoggedIn) Then
    Exit;

    Then have something in the outer loop like this

    Simba Code:
    If (Not P06_LoggedIn) Then
    P06_LogInPlayer;

    Example of how to include and set up login at the end of the Include thread OP, also if you make it like that, script must be able to be started anywhere along the loop, so it will work after logging back in,

    One more thing, make compass functions will not work/cause problems/maybe endless loops, if the mouse cursor is not over the game window, Because keyboard keys are not sent unless you have focus of the window, ActivateClient may fix that for the jar client, but not for the web browser application , Idk, can you test and tell me if it works for the client, if not then leave a Reply on the Include thread and I'll make compass functions check the cursor is in the window before trying to rotate
    Last edited by DannyRS; 02-11-2013 at 11:04 AM.


    Programming is like trying keep a wall of shifting sand up, you fix one thing but somewhere else starts crumbling

  3. #3
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by DannyRS View Post
    Nice release, I just had a look, are you using bitmaps for the right clicked options?

    You could try this, it should work for all right click stuff, and I think the text is 100% accurate on the menu, as it's all one color

    Simba Code:
    P06_ChooseOptionMulti(['Withdraw All','All']); //is there a - between the words?

    You might want to add exit's to your loops if you disconnect, and maybe add the loginplayer Include,

    Simba Code:
    If (Not P06_LoggedIn) Then
    Exit;

    Then have something in the outer loop like this

    Simba Code:
    If (Not P06_LoggedIn) Then
    P06_LogInPlayer;

    Example of how to include and set up login at the end of the Include thread OP, also if you make it like that, script must be able to be started anywhere along the loop, so it will work after logging back in,

    One more thing, make compass functions will not work/cause problems/maybe endless loops, if the mouse cursor is not over the game window, Because keyboard keys are not sent unless you have focus of the window, ActivateClient may fix that for the jar client, but not for the web browser application , Idk, can you test and tell me if it works for the client, if not then leave a Reply on the Include thread and I'll make compass functions check the cursor is in the window before trying to rotate
    Indeed I was using bitmaps for the right clicks, I never knew that other function was there so thanks for letting me know. I replaced all the bitmaps with this function and it seems to be working perfectly!

    I added various login checks to almost every loop and it seems to be working smoothly by logging back in and continuing the script: Albeit a little inefficiently as sometimes it will complete an action that has already been done BUT it still manages to continue with the script which was my main aim. For example after logging out/back in it may run to the range to get ready to cook fish despite there already being a full inventory of cooked fish, it will simply get to the range, realise there is nothing raw to cook and run back to the bank and start again. There are probably a few cases like this but they aren't that important for me to iron out at the minute since they only waste a few seconds. Apologies for the scruffy additions to the script as they don't look very pretty and i'm not even sure I am using things right, I imagine a lot of it could be done a lot better in simpler ways however this is all learning for me and I enjoy it!

    As for the activate client function it seems to be working fine for me using the jar file. I also made it attempt to click the inventory tab before it sorts the angle and compass out to ensure it has clicked on the client for people using the webclient, is that okay?

    Thanks for your help and advice though I really appreciate it.

  4. #4
    Join Date
    Jan 2013
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    3 Post(s)

    Default

    Error] C:\Simba\Scripts\JanusCatherbyCookerV3.simba(81:11 ): Duplicate identifier 'P06_DECLAREPLAYER' at line 80
    Compiling failed.

  5. #5
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by persecuted View Post
    Error] C:\Simba\Scripts\JanusCatherbyCookerV3.simba(81:11 ): Duplicate identifier 'P06_DECLAREPLAYER' at line 80
    Compiling failed.
    Hmm I don't get this error, do you have the latest pr06 includes installed and have you entered your username and password into the script?

    I think you just need to re-download and install the pr06 includes.
    Last edited by Janus; 02-12-2013 at 07:59 PM.

  6. #6
    Join Date
    Feb 2013
    Posts
    74
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Sorry for the lack of information, but this script didn't work for me. Ran once for like 1 min. And the script miss licked outside of the cooking place and couldn't recover. And yes I have all the includes, etc. and I started it right like you said

  7. #7
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by voltag00 View Post
    Sorry for the lack of information, but this script didn't work for me. Ran once for like 1 min. And the script miss licked outside of the cooking place and couldn't recover. And yes I have all the includes, etc. and I started it right like you said
    I've never had this problem and i've run the script for 17 hours collectively.
    Do you know if it miss-clicked when trying to walk to the range with the mini-map or if it miss-clicked when clicking on the range to cook the lobs? I'd love to get this sorted for you. Does the compass set itself to north and is the screen angle changed automatically when you start the script?

  8. #8
    Join Date
    Feb 2013
    Posts
    74
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Quote Originally Posted by Janus View Post
    I've never had this problem and i've run the script for 17 hours collectively.
    Do you know if it miss-clicked when trying to walk to the range with the mini-map or if it miss-clicked when clicking on the range to cook the lobs? I'd love to get this sorted for you. Does the compass set itself to north and is the screen angle changed automatically when you start the script?
    Thanks. I'm not sure. I'm currently mining right now, but when I cook again I'll let you know.

  9. #9
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by voltag00 View Post
    Thanks. I'm not sure. I'm currently mining right now, but when I cook again I'll let you know.
    Okay thanks, just so you know I set the script up to update the status bar on the bottom of the simba window with whatever the script is attempting to do at that current time so it would be nice to know what is says in there before the script stops working for you. I've tweaked the script again and will be uploading the latest version in a minute so make sure you use that if you try out the script again.

  10. #10
    Join Date
    Feb 2013
    Posts
    74
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Quote Originally Posted by Janus View Post
    Okay thanks, just so you know I set the script up to update the status bar on the bottom of the simba window with whatever the script is attempting to do at that current time so it would be nice to know what is says in there before the script stops working for you. I've tweaked the script again and will be uploading the latest version in a minute so make sure you use that if you try out the script again.
    Okay thanks

  11. #11
    Join Date
    Jun 2007
    Posts
    117
    Mentioned
    0 Post(s)
    Quoted
    16 Post(s)

    Default

    This script is awesome, thanks for the contribution.. Now i can finally cook 12k lobsters and hopefully finish a shark fishing script!

  12. #12
    Join Date
    Feb 2013
    Posts
    74
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    This script is good but it's not reliable. I downloaded the new version of the script and even downloaded the new includes. It runs well until either a door closer comes and starts closing the cooking range door, thus messing up the script. Also, if there is a small lag, it will mess up the script and make it run outside of the range. It will start clicking at the wrong times and ultimately stop the script

  13. #13
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by voltag00 View Post
    This script is good but it's not reliable. I downloaded the new version of the script and even downloaded the new includes. It runs well until either a door closer comes and starts closing the cooking range door, thus messing up the script. Also, if there is a small lag, it will mess up the script and make it run outside of the range. It will start clicking at the wrong times and ultimately stop the script
    Yeah I know door closers will ruin it! I might add a feature that will attempt to open the door in future. However it shouldn't mess up the script because it will simply keep walking back to the bank until it can get back to the range again. Even in times of massive lag i've never had the script click outside of the range though (and again, even if it does click outside the range it should always run back to the bank when it realises nothings being cooked :S), i've had it running almost perfectly for 10 hours a day for the past 3 days and have never run into any problems. Maybe it's destined to run only for me perfectly :P

  14. #14
    Join Date
    Feb 2013
    Posts
    74
    Mentioned
    1 Post(s)
    Quoted
    30 Post(s)

    Default

    Quote Originally Posted by Janus View Post
    Yeah I know door closers will ruin it! I might add a feature that will attempt to open the door in future. However it shouldn't mess up the script because it will simply keep walking back to the bank until it can get back to the range again. Even in times of massive lag i've never had the script click outside of the range though (and again, even if it does click outside the range it should always run back to the bank when it realises nothings being cooked :S), i've had it running almost perfectly for 10 hours a day for the past 3 days and have never run into any problems. Maybe it's destined to run only for me perfectly :P
    Haha. Well, next time I run it, I will try to remember and record it to show you what happens

  15. #15
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by jman1208 View Post
    This script is awesome, thanks for the contribution.. Now i can finally cook 12k lobsters and hopefully finish a shark fishing script!
    I've only just noticed this post! How's the script been working with you so far? Any problems or has it been running smoothly? I've cooked well over 14k lobsters with it so far I can't even imagine doing them by hand! I would LOVE a shark fishing script if you make one in future.

  16. #16
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Updated 14 Feb. Be sure to get the newest update to ensure working script!

  17. #17
    Join Date
    Jan 2013
    Posts
    14
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    Exception in Script: Unable to find file 'P06Include/P06Include.Simba' used from 'C:\Simba\Scripts\JanusCatherbyCookerV4.2.simba'
    Help me i have done exactly what they say me to do in here but it won't work plz help.I have put all the files where they are supposed to be, reply as soon as possible!
    http://villavu.com/forum/showthread.php?t=95916

  18. #18
    Join Date
    Jan 2013
    Posts
    49
    Mentioned
    0 Post(s)
    Quoted
    14 Post(s)

    Default

    Quote Originally Posted by akiponki View Post
    Exception in Script: Unable to find file 'P06Include/P06Include.Simba' used from 'C:\Simba\Scripts\JanusCatherbyCookerV4.2.simba'
    Help me i have done exactly what they say me to do in here but it won't work plz help.I have put all the files where they are supposed to be, reply as soon as possible!
    http://villavu.com/forum/showthread.php?t=95916

    Do you have it like this?

  19. #19
    Join Date
    Jan 2012
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    5 Post(s)

    Default

    mine just keep walking from the bank to the range can someone help im kinda new.

  20. #20
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by bdog1249 View Post
    mine just keep walking from the bank to the range can someone help im kinda new.
    Are you trying to cook lobs?

  21. #21
    Join Date
    Jan 2013
    Posts
    14
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    Okay so now i got the include working i think but it walks to the range presses the lobster and presses the range and the cook thing pops up, then the bad thing happends, it does not cllick on the cook lobster thing and tried to click the lobster and the range all the time but does not cook.I mean it does not click after it had clicked on the range with lobster.

  22. #22
    Join Date
    Jan 2012
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    5 Post(s)

    Default

    Quote Originally Posted by Janus View Post
    Are you trying to cook lobs?
    yes i am

  23. #23
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by akiponki View Post
    Okay so now i got the include working i think but it walks to the range presses the lobster and presses the range and the cook thing pops up, then the bad thing happends, it does not cllick on the cook lobster thing and tried to click the lobster and the range all the time but does not cook.I mean it does not click after it had clicked on the range with lobster.
    It's still working for me fine. Do you have your client brightness settings set to very bright? Something tells me it could be the p06_include UpChars. Do you have all the font image files in c:\Simba\Fonts\P06UpChars\ ?
    Last edited by Janus; 02-16-2013 at 04:32 PM.

  24. #24
    Join Date
    Jan 2012
    Posts
    8
    Mentioned
    0 Post(s)
    Quoted
    5 Post(s)

    Default

    i think it is my include because no bot works for me that uses that. Also when i try and run you bot now it gives me this. http://gyazo.com/004e7e34822c600701981b1d42aa7afd

  25. #25
    Join Date
    Jan 2013
    Posts
    52
    Mentioned
    0 Post(s)
    Quoted
    19 Post(s)

    Default

    Quote Originally Posted by bdog1249 View Post
    i think it is my include because no bot works for me that uses that. Also when i try and run you bot now it gives me this. http://gyazo.com/004e7e34822c600701981b1d42aa7afd
    Quote Originally Posted by bdog1249 View Post
    i think it is my include because no bot works for me that uses that. Also when i try and run you bot now it gives me this. http://gyazo.com/004e7e34822c600701981b1d42aa7afd
    Hmm it seems like it might be your includes. If I were you i'd delete simba and re-download it. Reinstall the include and ensure you put the files in the correct place:

    C:\Simba\Includes\P06Include\ < P06Include.simba in this folder.
    C:\Simba\Fonts\ < P06UpChars folder into this folder.

    See the include thread and follow this video for further instructions: http://www.youtube.com/watch?feature...&v=E3dfYdENGAU

Page 1 of 2 12 LastLast

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •