Results 1 to 23 of 23

Thread: Smidqe's Barbarian village powerfisher

  1. #1
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default Smidqe's Barbarian village powerfisher

    Current version: 1.02
    Current status: Working

    Finally managed to finish my second fully working script. I wanted to try something that I had thought for a long time, item detection without DTMs. So that's why this took such a long time to finish this. Yet it works very well in the long run and the colors are updated during the script.

    Also, this is the first time I actually utilize EOC. Because I don't really like the actionbar thing, I also have included the oldschool method of dropping items.

    So withouth any interruptions, the script:

    Description:
    Powerfishes in the barbarian village, drops them using EOC or oldschool method

    Features:
    • Spot switching with a DDTM
    • Color based item identification.
    • EOC and oldschool dropping support


    Instructions:
    1. Player must be in the north spot, no real harm done if not.
    2. Make sure you have atleast feathers or bait in your inventory. If you have fishing rod in your toolbelt and not in the inventory script will recognize it.
    3. Manually set the ability bar slots (drag items to slots).
    4. Make sure that SRL is fully updated
    5. Fill out necessary information
      Simba Code:
      (*~ Here starts the player setups, no need to touch above this ~*)
      const
        saveDebug = true;  //write to a debug log file?
        paintSMART = true; //paint on the smart?

      procedure DeclarePlayers;
      begin
        HowManyPlayers := 1;            //Change to amount of players wanted
        NumberOfPlayers(HowManyPlayers);
        CurrentPlayer := 0;            //0 is the first player as it goes like this 0, 1, 2..

        with Players[0] do
        begin
          (*~ General information ~*)
          Name   := '';   // Username
          Pass   := '';   // Password
          Nick   := '';   // Nickname, 3-4 letters (Used for progress reports)
          Active := true; // Using this player?
          Pin    := '';   // Just leave this empty

          (*~ What method to use? Fly fishing or bait fishing? ~*)
          Strings[PLAYER_METHOD] := 'fly';

          (*~ Do you want to use EOC dropping instead of oldschool dropping? ~*)
          Booleans[PLAYER_USE_EOC] := False;

          (*~ Which slots to utilize if EOC is utilised? ~*)
          Integers[PLAYER_SLOT_TROUT]  := 0;
          Integers[PLAYER_SLOT_SALMON] := 0;
          Integers[PLAYER_SLOT_PIKE]   := 0;

          (*~ Which XP bar to use for xp calculation? ~*)
          Integers[PLAYER_XP_BAR] := 1;

          (*~ Timing and such ~*)
          Integers[PLAYER_AMOUNT]  := 25;   // Number of loads, set to 0 if you don't want to stop because of the loads
          Integers[PLAYER_TTIME]   := 500;   // Total time (in minutes), set to 0 if you want to go forever or until the loads are met
          Integers[PLAYER_BREAK]   := 60;   // Breaking or switching after x minutes
          Integers[PLAYER_BTIME]   := 20;   // Time to break, +- random 3 minutes
        end;                                                                            
      end;
    6. Push play, and wait for SMART load
    7. Follow couple first loops to see if there is any issues


    Progress reports:
    Longest proggy from me, update stopped it
    Progress Report:
     ________________________________ 
    /________________________________\
    |     Powerfisher by Smidqe      |
    |________________________________|
    |________________________________|
    | - Version: 1.01                |
    | - Total runtime: 03:05:53      |
    |________________________________|
    |________________________________|
    | Player: 0                      |
    | - Nickname    :                |
    | - Time played : 02:35:46       |
    | - Method      : Fly            |
    | - Fish caught : 1527           |
    | - - Trout     : 866            |
    | - - Salmon    : 661            |
    | - Loads       : 58             |
    | - Experience  : 86230          |
    | - EXP/H       : 27833          |
    | - Level       : 76             |
    | - - Gained    : 0              |
    | - Breaks      : 1              |
    |________________________________|
    \________________________________/

    Version 1.0 testing
    Progress Report:
     ________________________________ 
    /________________________________\
    |     Powerfisher by Smidqe      |
    |________________________________|
    |________________________________|
    | - Version: 1                   |
    | - Total runtime: 02:25:47      |
    |________________________________|
    |________________________________|
    | Player: 0                      |
    | - Nickname    : ****           |
    | - Time played : 02:25:46       |
    | - Method      : Fly            |
    | - Fish caught : 1404           |
    | - - Trout     : 855            |
    | - - Salmon    : 549            |
    | - Experience  : 76450          |
    | - EXP/H       : 31464          |
    | - Level       : 76             |
    | - - Gained    : 0              |
    | - Breaks      : 2              |
    |________________________________|
    \________________________________/


    How to report bugs:
    • Describe the bug as detailed as possible, giving enough information regarding the issue is important.
    • If you can't describe it or you missed it completely, then include
    • Include the debug log if not too long otherwise from third to last progress report to the last line! Always include (atleast a part) the debug log!


    To come:
    • Suggest what I should add and I'll think about it.
    • Automatic location detection, is it in the northern or the southern spot.



    Bugs:
    • isNew doesn't fill the first color right away //It's not a big problem, it usually resolves in couple loops.
    • DDTM doesn't always work, depending on the amount of players around their dots may cover the trees resulting DDTM not being found. (Hopefully this is fixed in version 1.02)
    • Fish counting is off, but doesn't affect experience counting.



    Version history:
    • 1.0: Initial release
    • 1.01: Fixed if PLAYER_AMOUNT was 0 script would do one load and log out. Also fixed for not taking breaks if using single player (my bad). Added load count to progress report, also minor timing modifications hoping that the spot finding would be slightly faster. And also couple minor fixes that I already forgot
    • 1.02: Fixed isEquipment not switching back to inventory tab, hopefully fixed DDTM coordinates, minor timing modifications. Also now the script fills the correct actionbar slots if you have set the slots. Also I hope that I fixed the "feather" bug.
    • 1.03: Fixed out of range error caused by wrong length of colArr
    • 1.04: Fixed endless loop in the dropInv.


    Downloads:
    • 1.0: 2
    • 1.01: 25
    • 1.02: 80
    • 1.03: 44
    Attached Files Attached Files
    Last edited by Smidqe; 06-21-2013 at 07:15 AM.
    Rusting away

  2. #2
    Join Date
    May 2012
    Posts
    29
    Mentioned
    0 Post(s)
    Quoted
    7 Post(s)

    Default

    I tryed to set the [PLAYEr_AMOUNT := 0; so it would run 4 ever, but it did one load, then quit playing when i did load 9999 it runs for 9999 loads So you many need to look into that?

    new to post:

    Sometimes when a new spot arrives and the old one disappears, the script use long time to find the new spot, even if its right with the old one.
    Last edited by drittnothing; 03-21-2013 at 03:06 PM.

  3. #3
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by drittnothing View Post
    I tryed to set the [PLAYEr_AMOUNT := 0; so it would run 4 ever, but it did one load, then quit playing when i did load 9999 it runs for 9999 loads So you many need to look into that?

    new to post:

    Sometimes when a new spot arrives and the old one disappears, the script use long time to find the new spot, even if its right with the old one.
    My mistake, I had wrong constant there. I'll upload fix in a minute.

    It shouldn't take that long to find the spot, but I think that the tolerance needs to be stronger. Script could've also been in the middle of the antiban. I'll look into these at somepoint.

    E: Couple minor problems has risen. I'll fix those as soon as I can.
    Last edited by Smidqe; 03-21-2013 at 04:02 PM.
    Rusting away

  4. #4
    Join Date
    Feb 2012
    Location
    Canada
    Posts
    1,164
    Mentioned
    26 Post(s)
    Quoted
    433 Post(s)

  5. #5
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by StickToTheScript View Post
    This is a very interesting script. It likes to quit when i decides to not go to the other spot. Any ideas?
    Could you post a debug log (or atleast part of it)? I haven't encountered anything like that so I can't answer without the debug log.
    Rusting away

  6. #6
    Join Date
    Feb 2012
    Location
    Canada
    Posts
    1,164
    Mentioned
    26 Post(s)
    Quoted
    433 Post(s)

    Default

    Quote Originally Posted by Smidqe View Post
    Could you post a debug log (or atleast part of it)? I haven't encountered anything like that so I can't answer without the debug log.
    Yeah! Ill get right on that. Just gotta finish testing a bit of my script. I will be like an hour or two.

    Ok, here:

    Code:
    [grabColor]: Length(npc): 105
    [grabColor]: Length(tree green): 88
    [grabColor]: Length(tree green): 88
    [grabColor]: Length(tree green): 88
    [initDDTM]: DDTM for barbarian village is finished
    [setupPlayer]: DDTM failure, if it constantly fails (multiple tries) then report to thread!
    [isEquipment]: Tool finding: False
    [isEquipment]: Tool in toolBelt: True
    [isEquipment]: l = 35
    [isEquipment]: l = 69
    [isEquipment]: l = 33
    [isEquipment]: Inventory tab is not open!
    [isEquipment]: l = 80
    [setupPlayer]: Excluded slots(tools and bait): [0, 0]
    [isNew]: New items found, or colors are outdated!
    [isNew]: Colors: [0, 0, 0]
    [isEquipment]: l = 95
    [isEquipment]: Amount of feathers (or bait) left: 47784
    [findSpot]: Object wasn't found
    [startFishing]: Try: 1. Fishing spots were not found
    [findSpot]: Object wasn't found
    [startFishing]: Try: 2. Fishing spots were not found
    [findSpot]: Object wasn't found
    [startFishing]: Try: 3. Fishing spots were not found
    [startFishing]: No fish spots for 3 tries, exiting
    [setupMain]: Relocating our player
    [DDTMRelocate]: Failed to relocate, reason: no DDTM seen
    [isEquipment]: l = 95
    [isEquipment]: Amount of feathers (or bait) left: 47784
    [findSpot]: Object wasn't found
    [startFishing]: Try: 1. Fishing spots were not found
    [findSpot]: Length(TPA): 18
    [findSpot]: Current uptext: Lure Fishing spot / 3 more options
    [findSpot]: Object found at [361, 150, False]
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 0
    [setupMain]: notFishing count: 1
    [setupMain]: notFishing count: 2
     ________________________________ 
    /________________________________\
    |     Powerfisher by Smidqe      |
    |________________________________|
    |________________________________|
    | - Version: 1.01                |
    | - Total runtime: 00:02:42      |
    |________________________________|
    |________________________________|
    | Player: 0                      |
    | - Nickname    :                |
    | - Time played : 00:02:08       |
    | - Method      : Fly            |
    | - Loads       : 0              |
    | - Experience  : 1050           |
    | - EXP/H       : 23333          |
    | - Level       : 62             |
    | - - Gained    : 0              |
    | - Breaks      : 0              |
    |________________________________|
    \________________________________/
    [setupChecks]: Checks done
    [setupChecks]: Switching players, reason: spot switching failed
    [switchPlayer]: Player switching initiated
    NextPlayer(False)
    SwitchToPlayer(PlayerNo: 0, Active: False);
    Player is not Active...
    All players not active!
    [switchPlayer]: Player switching finished, last player: False
     ________________________________ 
    /________________________________\
    |     Powerfisher by Smidqe      |
    |________________________________|
    |________________________________|
    | - Version: 1.01                |
    | - Total runtime: 00:02:46      |
    |________________________________|
    |________________________________|
    | Player: 0                      |
    | - Nickname    :                |
    | - Time played : 00:02:15       |
    | - Method      : Fly            |
    | - Loads       : 0              |
    | - Experience  : 1050           |
    | - EXP/H       : 22771          |
    | - Level       : 62             |
    | - - Gained    : 0              |
    | - Breaks      : 0              |
    | - Reason      : spot switching failed|
    |________________________________|
    \________________________________/
    Successfully executed.
    File[C:\Users\**********\Downloads\Smidqe's powerFisher 26-03-13 at 01-33-25 PM.txt] has not been freed in the script, freeing it now.
    Last edited by StickToTheScript; 03-26-2013 at 06:39 PM.

  7. #7
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by StickToTheScript View Post
    Yeah! Ill get right on that. Just gotta finish testing a bit of my script. I will be like an hour or two.

    Ok, here:
    //snip
    Ah, now I understand. It failed to create the DDTM necessary for the spot switching. I'll fiddle with that.

    There's also a problem with the isEquipment as it apparently resulted as [0, 0], it doesn't switch to inventory tab after the toolbelt check, which is totally my fault.

    I'll fix these bugs tomorrow.

    //this was the crucial part:
    Progress Report:
    [initDDTM]: DDTM for barbarian village is finished
    [setupPlayer]: DDTM failure, if it constantly fails (multiple tries) then report to thread!
    [isEquipment]: Tool finding: False
    [isEquipment]: Tool in toolBelt: True
    [isEquipment]: l = 35
    [isEquipment]: l = 69
    [isEquipment]: l = 33
    [isEquipment]: Inventory tab is not open!
    [isEquipment]: l = 80
    [setupPlayer]: Excluded slots(tools and bait): [0, 0]
    Rusting away

  8. #8
    Join Date
    Feb 2012
    Location
    Canada
    Posts
    1,164
    Mentioned
    26 Post(s)
    Quoted
    433 Post(s)

    Default

    Quote Originally Posted by Smidqe View Post
    Ah, now I understand. It failed to create the DDTM necessary for the spot switching. I'll fiddle with that.

    There's also a problem with the isEquipment as it apparently resulted as [0, 0], it doesn't switch to inventory tab after the toolbelt check, which is totally my fault.

    I'll fix these bugs tomorrow.

    //this was the crucial part:
    Progress Report:
    [initDDTM]: DDTM for barbarian village is finished
    [setupPlayer]: DDTM failure, if it constantly fails (multiple tries) then report to thread!
    [isEquipment]: Tool finding: False
    [isEquipment]: Tool in toolBelt: True
    [isEquipment]: l = 35
    [isEquipment]: l = 69
    [isEquipment]: l = 33
    [isEquipment]: Inventory tab is not open!
    [isEquipment]: l = 80
    [setupPlayer]: Excluded slots(tools and bait): [0, 0]
    Yeah. Other than that its awesome! So, if you fix it, be sure to let me know and i will happily try it out.

  9. #9
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Version 1.02 released! Changes in the first post.

    Progress report from testing, ran out of feathers.
    Progress Report:
     ________________________________ 
    /________________________________\
    |     Powerfisher by Smidqe      |
    |________________________________|
    |________________________________|
    | - Version: 1.02                |
    | - Total runtime: 03:21:38      |
    |________________________________|
    |________________________________|
    | Player: 0                      |
    | - Nickname    :                |
    | - Time played : 02:58:31       |
    | - Method      : Fly            |
    | - Fish caught : 1949           |
    | - - Trout     : 1164           |
    | - - Salmon    : 785            |
    | - Loads       : 73             |
    | - Experience  : 105020         |
    | - EXP/H       : 31250          |
    | - Level       : 79             |
    | - - Gained    : 1              |
    | - Breaks      : 1              |
    | - Reason      : no feathers or bait|
    |________________________________|
    \________________________________/
    Rusting away

  10. #10
    Join Date
    Mar 2013
    Posts
    12
    Mentioned
    0 Post(s)
    Quoted
    4 Post(s)

    Default

    [Error] C:\Simba\Includes\SRL/SRL/misc/SmartParams.Simba(295:135): Invalid number of parameters at line 294
    Compiling failed.

    help??

  11. #11
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by leftysoulz View Post
    [Error] C:\Simba\Includes\SRL/SRL/misc/SmartParams.Simba(295:135): Invalid number of parameters at line 294
    Compiling failed.

    help??
    You probably have SMART 8 installed, so replace these:
    Simba Code:
    {$DEFINE SMART}
    {$i srl/srl.simba}
    {$i srl/srl/misc/debug.simba}
    {$IFDEF SMART}
      {$i srl/srl/misc/smartGraphics.simba}
    {$ENDIF}

    with these:
    Simba Code:
    {$DEFINE SMART8}
    {$i srl/srl.simba}
    {$i srl/srl/misc/debug.simba}
    {$IFDEF SMART8}
      {$i srl/srl/misc/smartGraphics.simba}
    {$ENDIF}
    Rusting away

  12. #12
    Join Date
    Oct 2012
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Error: Out Of Range at line 1407
    The following DTMs were not freed: [SRL - Lamp bitmap, 1, 2, 3, 4]
    The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap, SRL - Options Bitmap]
    File[C:\Users\Link\Downloads\Smidqe's powerFisher 15-05-13 at 03-09-45 PM.txt] has not been freed in the script, freeing it now.
    Last edited by lil bopeep; 05-15-2013 at 05:35 AM.

  13. #13
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by lil bopeep View Post
    Error: Out Of Range at line 1407
    The following DTMs were not freed: [SRL - Lamp bitmap, 1, 2, 3, 4]
    The following bitmaps were not freed: [SRL - Mod bitmap, SRL - Admin bitmap, SRL - Flag bitmap, SRL - NavBar Bitmap, SRL - Options Bitmap]
    File[C:\Users\Link\Downloads\Smidqe's powerFisher 15-05-13 at 03-09-45 PM.txt] has not been freed in the script, freeing it now.
    Quite informative bug report...

    But anyway, it seems that the length of colArr < 3 or it's a whopping 0. My mistake, I never set the array length.

    Also was this at the startup or during runtime?
    I'll fix this in 1.03, once I finish it. (Being quite busy, as of now)
    Rusting away

  14. #14
    Join Date
    Oct 2012
    Posts
    4
    Mentioned
    0 Post(s)
    Quoted
    1 Post(s)

    Default

    Quote Originally Posted by Smidqe View Post
    Quite informative bug report...

    But anyway, it seems that the length of colArr < 3 or it's a whopping 0. My mistake, I never set the array length.

    Also was this at the startup or during runtime?
    I'll fix this in 1.03, once I finish it. (Being quite busy, as of now)
    It occurred right after the tool check.

  15. #15
    Join Date
    May 2013
    Posts
    50
    Mentioned
    0 Post(s)
    Quoted
    28 Post(s)

    Default

    It's fixed now? It still appears.

  16. #16
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by netz View Post
    It's fixed now? It still appears.
    I have fixed it, but haven't uploaded the new version yet. Might do it today.

    E: Version 1.03 uploaded!
    Last edited by Smidqe; 05-21-2013 at 06:37 AM.
    Rusting away

  17. #17
    Join Date
    May 2013
    Posts
    50
    Mentioned
    0 Post(s)
    Quoted
    28 Post(s)

    Default

    Quote Originally Posted by Smidqe View Post
    I have fixed it, but haven't uploaded the new version yet. Might do it today.

    E: Version 1.03 uploaded!
    Works, thanks a lot!

  18. #18
    Join Date
    Jan 2013
    Posts
    3
    Mentioned
    0 Post(s)
    Quoted
    2 Post(s)

    Default

    im getting logged out after 5 minutes use, due to "spot switching failed" other than that, works great

  19. #19
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by Ceris3 View Post
    im getting logged out after 5 minutes use, due to "spot switching failed" other than that, works great
    That means that the DDTM isn't found. I'll look into it in eventually since I'm quite busy right now.
    Rusting away

  20. #20
    Join Date
    Jun 2013
    Posts
    22
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    i seem to have come across a problem with this script, after the load drops it just sitters there and repeats and repeats.. "dropping trout" i sat and wait but for 5m it just sat there and kept "dropping" trout tht wasnt even there. please help

  21. #21
    Join Date
    Jun 2013
    Posts
    4
    Mentioned
    1 Post(s)
    Quoted
    3 Post(s)

    Default

    ODTM Updater Enabled!
    [Error] C:\Simba\Includes\SRL/SRL/misc/SmartParams.Simba(282:145): Invalid number of parameters at line 281
    Compiling failed.

    Can you help?

  22. #22
    Join Date
    Sep 2010
    Location
    Finland
    Posts
    299
    Mentioned
    8 Post(s)
    Quoted
    37 Post(s)

    Default

    Quote Originally Posted by went2thedrkside View Post
    i seem to have come across a problem with this script, after the load drops it just sitters there and repeats and repeats.. "dropping trout" i sat and wait but for 5m it just sat there and kept "dropping" trout tht wasnt even there. please help
    Ah, I tested it and was able to reproduce the bug, reason why it did continuosly loop the dropping was that length of the exSlots is always 2, and if you have fishing rod in the toolbelt it finds only one item in the inventory and therefore dropInv will never give a result. I have fixed it and I'll be uploading 1.04 today.

    Quote Originally Posted by runescapebot96 View Post
    ODTM Updater Enabled!
    [Error] C:\Simba\Includes\SRL/SRL/misc/SmartParams.Simba(282:145): Invalid number of parameters at line 281
    Compiling failed.

    Can you help?
    You might want to change {$DEFINE SMART} to {$DEFINE SMART8}, that usually solves the problem. If not then you might want to make a thread in the help forums, since this error isn't script related.

    E: I've been really busy lately, so don't expect any updates on this script anytime soon (1.04 ->). Probably the next update will be for SRL 6 and Lape
    Rusting away

  23. #23
    Join Date
    Jun 2013
    Posts
    22
    Mentioned
    0 Post(s)
    Quoted
    12 Post(s)

    Default

    awesome! thanks

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •